Comments on: Which code layout do you like more?

By: miles

miles — Mon, 27 Jul 2009 22:03:58 +0000

return ( b ? h(g(a)) : g(a))

… assuming ternary operators…

By: miles

miles — Mon, 27 Jul 2009 18:03:58 +0000

return ( b ? h(g(a)) : g(a))

… assuming ternary operators…

By: Brandon Corfman

Brandon Corfman — Thu, 25 Jun 2009 15:03:25 +0000

Shouldn't the function name be “price” instead? Why introduce a variable just for naming when the function name serves that purpose?

By: Freestyle

Freestyle — Thu, 25 Jun 2009 14:54:34 +0000

Second one would be great for me! I liked both of these btw!

By: Michael

Michael — Sat, 20 Jun 2009 03:17:14 +0000

With multiple return points I find myself spelling out implicit else statement:

def(a,b):
__if b:
____return h(g(a))
__else:
____return g(a)

By: seenxu

seenxu — Fri, 19 Jun 2009 23:08:03 +0000

I'd prefer the first one, easy to read, easy to understand.

By: rgz

rgz — Fri, 19 Jun 2009 18:08:07 +0000

I on the other hand love multiple return statements in loops and –while using php– switches. I actually find that situation a lot using switches.

In some switches I don't use break at all since all my cases end with return. Some times however I have to do additional work before getting out of the function, then it's temp variable time again.

By: Titus Brown

Titus Brown — Fri, 19 Jun 2009 17:54:47 +0000

For me, it depends on the rest of the code in the function. Multiple obvious return statements aren't "bad":

def f(...):
if param is bad:
return None

... do stuff ...
return answer

but I don't like having returns sprinkled throughout the code, and especially not in loops, where it can complicate the logic of the execution flow.

By: elzapp

elzapp — Fri, 19 Jun 2009 12:04:54 +0000

the indentation disappeared. Using _ as space:
def(a,b):
__if b:
____return h(g(a))
__return g(a)

By: elzapp

elzapp — Fri, 19 Jun 2009 12:03:52 +0000

How about
def(a,b):
if b:
return h(g(a))
return g(a)